From 242216cab1ffc2ea4b14bf32550f5936e8ef8b1b Mon Sep 17 00:00:00 2001 From: Nicolas De Loof Date: Tue, 7 Jul 2020 11:50:42 +0200 Subject: [PATCH] Reject compose file not setting service image Signed-off-by: Nicolas De Loof --- ecs/pkg/amazon/backend/cloudformation.go | 1 + ecs/pkg/amazon/backend/convert.go | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/ecs/pkg/amazon/backend/cloudformation.go b/ecs/pkg/amazon/backend/cloudformation.go index 3df5b8ab..5a096237 100644 --- a/ecs/pkg/amazon/backend/cloudformation.go +++ b/ecs/pkg/amazon/backend/cloudformation.go @@ -40,6 +40,7 @@ func (c *FargateCompatibilityChecker) CheckPortsPublished(p *types.ServicePortCo } if p.Published != p.Target { c.Error("published port can't be set to a distinct value than container port") + p.Published = p.Target } } diff --git a/ecs/pkg/amazon/backend/convert.go b/ecs/pkg/amazon/backend/convert.go index 0eace3a6..196ff9ac 100644 --- a/ecs/pkg/amazon/backend/convert.go +++ b/ecs/pkg/amazon/backend/convert.go @@ -17,6 +17,10 @@ import ( ) func Convert(project *types.Project, service types.ServiceConfig) (*ecs.TaskDefinition, error) { + if service.Image == "" { + return nil, fmt.Errorf("service %s doesn't define a Docker image to run", service.Name) + } + cpu, mem, err := toLimits(service) if err != nil { return nil, err