silva
/
compose
mirror of https://github.com/viniciusfdasilva/compose.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't return error if we can't parse the creds 

We just continue on to the next credentials
This commit is contained in:
Djordje Lukic 2020-08-05 15:08:40 +02:00
parent e0f8289f1c
commit 9103215bf3
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
aci/convert/registrycredentials.go
View File

@ -73,8 +73,10 @@ func getRegistryCredentials(project compose.Project, registryLoader registryConf
var registryCreds []containerinstance.ImageRegistryCredential var registryCreds []containerinstance.ImageRegistryCredential
for name, oneCred := range allCreds { for name, oneCred := range allCreds {
parsedURL, err := url.Parse(name) parsedURL, err := url.Parse(name)
// Credentials can contain some garbage, we don't return the error here
// because we don't care about these garbage creds.
if err != nil { if err != nil {
return nil, err continue
} }
hostname := parsedURL.Host hostname := parsedURL.Host