diff --git a/local/compose/create.go b/local/compose/create.go index 6e445ce7..e94a98d5 100644 --- a/local/compose/create.go +++ b/local/compose/create.go @@ -296,6 +296,41 @@ func buildContainerMountOptions(p types.Project, s types.ServiceConfig, inherit } mounts = append(mounts, mount) } + + secretsDir := "/run/secrets" + for _, secret := range s.Secrets { + target := secret.Target + if secret.Target == "" { + target = filepath.Join(secretsDir, secret.Source) + } else if !filepath.IsAbs(secret.Target) { + target = filepath.Join(secretsDir, secret.Target) + } + + definedSecret := p.Secrets[secret.Source] + if definedSecret.External.External { + return nil, fmt.Errorf("unsupported external secret %s", definedSecret.Name) + } + + if contains(inherited, target) { + // remove inherited mount + pos := indexOf(inherited, target) + if pos >= 0 { + mounts = append(mounts[:pos], mounts[pos+1]) + inherited = append(inherited[:pos], inherited[pos+1]) + } + } + + mount, err := buildMount(p, types.ServiceVolumeConfig{ + Type: types.VolumeTypeBind, + Source: definedSecret.File, + Target: target, + }) + if err != nil { + return nil, err + } + mounts = append(mounts, mount) + } + return mounts, nil } diff --git a/local/compose/util.go b/local/compose/util.go index dd9cbbcf..b0af71ca 100644 --- a/local/compose/util.go +++ b/local/compose/util.go @@ -38,3 +38,12 @@ func contains(slice []string, item string) bool { } return false } + +func indexOf(slice []string, item string) int { + for i, v := range slice { + if v == item { + return i + } + } + return -1 +}