silva
/
compose
mirror of https://github.com/viniciusfdasilva/compose.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8834 from akerouanton/fix-start-0-replicas 

v2: Don't try to start services with 0 replicas
This commit is contained in:
Ulysses Souza 2021-11-23 14:53:08 +01:00 committed by GitHub
parent 382c1cd68e 5f392258cb
commit 9eb69465b7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/compose/convergence.go
View File

@ -559,6 +559,10 @@ func (s *composeService) isServiceCompleted(ctx context.Context, project *types.
} }
func (s *composeService) startService(ctx context.Context, project *types.Project, service types.ServiceConfig) error { func (s *composeService) startService(ctx context.Context, project *types.Project, service types.ServiceConfig) error {
if service.Deploy != nil && service.Deploy.Replicas != nil && *service.Deploy.Replicas == 0 {
return nil
}
err := s.waitDependencies(ctx, project, service.DependsOn) err := s.waitDependencies(ctx, project, service.DependsOn)
if err != nil { if err != nil {
return err return err
@ -579,7 +583,7 @@ func (s *composeService) startService(ctx context.Context, project *types.Projec
if scale, err := getScale(service); err != nil && scale == 0 { if scale, err := getScale(service); err != nil && scale == 0 {
return nil return nil
} }
return fmt.Errorf("no containers to start") return fmt.Errorf("service %q has no container to start", service.Name)
} }
w := progress.ContextWriter(ctx) w := progress.ContextWriter(ctx)