From bb58290eebdad304d13418feae1e3a8704e9fec3 Mon Sep 17 00:00:00 2001 From: "guillaume.tardif" Date: Wed, 2 Sep 2020 17:31:04 +0200 Subject: [PATCH] invoke browser with Run rather than Start, to get errors (on wsl no interop setup, and more generally if the browser app returns an error) Signed-off-by: guillaume.tardif --- aci/login/helper.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/aci/login/helper.go b/aci/login/helper.go index 21739cc5..de6d4352 100644 --- a/aci/login/helper.go +++ b/aci/login/helper.go @@ -102,13 +102,13 @@ func openbrowser(address string) error { switch runtime.GOOS { case "linux": if isWsl() { - return exec.Command("wslview", address).Start() + return exec.Command("wslview", address).Run() } - return exec.Command("xdg-open", address).Start() + return exec.Command("xdg-open", address).Run() case "windows": - return exec.Command("rundll32", "url.dll,FileProtocolHandler", address).Start() + return exec.Command("rundll32", "url.dll,FileProtocolHandler", address).Run() case "darwin": - return exec.Command("open", address).Start() + return exec.Command("open", address).Run() default: return fmt.Errorf("unsupported platform") }