Commit Graph

96 Commits

Author SHA1 Message Date
Guillaume Tardif 0dfea32250 Revert "Temporarily disable some red ACI tests, to be put reverted once the platform is back to green (hopefully in a day or 2)"
This reverts commit b10acc1a60.

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-12 14:08:22 +02:00
Ulysses Souza 99186b1d04 Look for all mounts before removing a volume
This checks the volume mounts of all container groups from all
resource groups before removing a volume/fileshare

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-09 14:39:21 +02:00
Guillaume Tardif 4f87422a79 more debug info when ports available but hostIP is empty ; Seems to be a race where container has status running but not yet an IP allocated
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-09 14:09:09 +02:00
Ulysses Souza 019268dded Fix e2e tests on comparing with empty string
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-09 13:21:17 +02:00
Guillaume Tardif 6516632ecf Add resource reservations to container inspect
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 17:47:16 +02:00
Guillaume Tardif b1edfb6507 Change inspect json output to group things a bit more nicely, and more like Moby json output
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 17:03:30 +02:00
guillaume.tardif cd09351b0a Fix ACI E2E test on windows (file path)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-07 10:38:33 +02:00
Guillaume Tardif 9cc914ef07 No need for docker dependency for CopyDir, and yaml parser.
No need for multiport compose file with volumes

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-06 17:54:26 +02:00
Ulysses Souza f8a3aec64d Add aci volumes e2e test
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-06 17:22:57 +02:00
Guillaume Tardif b10acc1a60 Temporarily disable some red ACI tests, to be put reverted once the platform is back to green (hopefully in a day or 2)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-06 13:29:27 +02:00
Guillaume Tardif 71238b261d Running tests in many regions to avoid per region limit when we run too many // things in the CI
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-05 09:36:43 +02:00
Ulysses Souza e4fff081db
Merge pull request #711 from docker/fix_aci_500
ACI tests : Wait for http status and retry if necessary.
2020-10-02 17:30:23 +02:00
Guillaume Tardif a07b1db9f1 Wait for http status and retry if necessary. We were getting 500 errors because database is not ready initially
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-01 18:09:34 +02:00
Guillaume Tardif 7941e048a1 Fix ACI e2e : now we support passing commands, set `--domainname` before the image in the cmd
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-01 12:56:47 +02:00
Guillaume Tardif ca35ccfb0e ACI Volumes : create takes one required arg, instead of required flag `--fileshare` (we still have required flag `--storage-account` specifically for ACI)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-24 17:10:32 +02:00
Guillaume Tardif 7eda96bea4 Fix nil pointer when creating volume with “” storage account
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-24 12:59:29 +02:00
Guillaume Tardif 334ebf5f75 Implement --domainname flag on compose up, also defining compose extension "x-aci-domain-name" to store ACI DNSLabelName.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-22 14:41:31 +02:00
Guillaume Tardif 701d1b834e ACI: allow users to set DNSLabelName and deploy containers with fqdn like `myapp.eastus.azurecontainers.io`
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-22 14:41:31 +02:00
Guillaume Tardif 7abdb085c0
Merge pull request #637 from docker/volume_tests
Added tests on ACI volume conversion, mock storageLogin required to get storage account keys
2020-09-22 14:40:46 +02:00
Guillaume Tardif 0092de6df1 Added tests on ACI volume conversion, mock storageLogin required to get storage account keys
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-22 14:24:12 +02:00
Chris Crone d154c41586 Update copyright
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-09-22 12:13:00 +02:00
Guillaume Tardif 57ded74aee
Merge pull request #598 from docker/encode_env_values
Properly send env variables containing “=“ in their value in ACI payload. Also properly send quoted values
2020-09-10 17:17:02 +02:00
Guillaume Tardif 98f0064fe9 Properly send env variables containing “=“ in their value in ACI payload. Also properly send quoted values
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 17:03:34 +02:00
Guillaume Tardif 0b3fdb637d Change volume IDs from “storageaccount@fileshare“ to “storageaccount/fileshare”
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 16:07:22 +02:00
Guillaume Tardif 80d23a6097 Removed NAME from `volume ls` output, allow `volume delete <ID>` using IDs from `volume ls`.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 09:14:39 +02:00
Guillaume Tardif 96d785a5bd Added volume delete, can delete juste a file share or the storage account if confirmed
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 16:32:16 +02:00
Guillaume Tardif 2f672f6c4c Volume e2e test
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 15:30:50 +02:00
Guillaume Tardif 171ab1bd0c Most common scenario is to use `compose ls` without name option, and list all stacks
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 10:11:51 +02:00
Guillaume Tardif a2e0f16f07
Merge pull request #592 from docker/fix_compose_ls_tests
Fix `compose ls` tests
2020-09-08 09:06:39 +02:00
aiordache 9098405313 Fix `compose ls` tests
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-09-07 17:06:35 +02:00
Chris Crone 7545485f78
Merge pull request #591 from docker/flaky-aci
Attempt to fix flaky ACI tests
2020-09-07 17:05:58 +02:00
Chris Crone e4e77bd198 e2e.aci: Retry flaky HTTP GET requests
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-09-07 13:43:49 +02:00
Guillaume Tardif d06aa2827f Move containers, compose, secrets to /api
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-07 13:22:08 +02:00
Guillaume Tardif 7138ecc899 ACI : when following logs (actually polling logs), stop polling when the container is not running anymore.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-04 15:46:35 +02:00
Guillaume Tardif b0c50ed6dd Implement compose ps on ACI
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-28 17:43:18 +02:00
Guillaume Tardif ed395a1e64 Display nice message on context creation (message taken from Moby cli)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-26 18:09:01 +02:00
Guillaume Tardif ad5c465bd1
Merge pull request #485 from docker/repo-rename
Rename docker/api -> docker/compose-cli
2020-08-25 15:58:51 +02:00
Guillaume Tardif 981665b02c Better renaming
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-24 16:09:20 +02:00
Guillaume Tardif 2bac8cf94e Fix linter
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 21:28:15 +02:00
Guillaume Tardif 7204692e3a Use test name instead of arbitrary string that needs to be different for each test
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 18:46:31 +02:00
Guillaume Tardif 30884ad91a Display executed commands (prefixed with test name for readable logs in // runs)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 18:46:17 +02:00
Guillaume Tardif da6334f415 Renaming, expect commands to succeed by default (removed a bunch of res.Assert(success) )
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 18:45:38 +02:00
Chris Crone 4c6280b0e9 Rename docker/api -> docker/compose-cli
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-21 17:28:39 +02:00
Guillaume Tardif e19a740102 Adapt aci compose test reflecting the change.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 09:59:50 +02:00
Guillaume Tardif 64dd7a5674 Check that AZURE creds are defined when running E2E tests
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-19 11:58:02 +02:00
Guillaume Tardif 6ad48b9212 Updated ACI e2e flaky test to avoid failing when https://github.com/docker/desktop-microsoft/issues/49 happens
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-18 12:42:01 +02:00
Guillaume Tardif 27e7a0ced3
Merge pull request #475 from docker/aci_volume_keys
Get storage account key from azure login, no need to specify it in compose file or run -v option
2020-08-14 17:55:56 +02:00
Guillaume Tardif a86854effd Slightly update timeout, failing on windows nodes (https://github.com/docker/api/runs/984443961). Didn’t want to make it too long either, avoid waiting 2 mins to see when it’s failing. We’ll update this again if we see it’s not enough. 2020-08-14 12:42:19 +02:00
Guillaume Tardif 3a60c957ae Get storage account key from azure login, no need to specify it in compose file or run -v option 2020-08-14 12:26:09 +02:00
Guillaume Tardif 104b3d4dc8 Change ACI test region to eastus2. Improve error output when waiting for container status 2020-08-14 12:12:06 +02:00