Commit Graph

  • f0efaf7a79 Remove node test, node-sdk has these tests Djordje Lukic 2020-06-15 10:06:56 +0200
  • 98f7a8e1aa When can not load config file, the previous cli is displaying a WARNING message, but continues with default context, we should do the same. This happened in some desktop e2e tests where the config file is not set properly in WSL2 environment, see https://github.com/docker/pinata/pull/14062 Guillaume Tardif 2020-06-15 10:04:01 +0200
  • bc1b2b778a
    Merge pull request #211 from docker/wrap_context_error Guillaume Tardif 2020-06-15 09:58:00 +0200
  • dda4b0f3bf Wrap error cause so that we can understand why the cli cannot determine current context. This happened in Desktop WSL2 tests, we’re blind here : https://ci-next.docker.com/teams-desktop/blue/organizations/jenkins/desktop%2Fdesktop-test-single-pr-win/detail/desktop-test-single-pr-win/120692/pipeline Guillaume Tardif 2020-06-13 16:25:29 +0200
  • f19fe9e188
    Merge pull request #208 from metcalfc/wsl2 Djordje Lukic 2020-06-13 02:41:48 -0700
  • 7743ae3bb1
    Merge pull request #209 from metcalfc/make_serve Djordje Lukic 2020-06-13 02:41:28 -0700
  • 4cf5004c4b
    Merge pull request #210 from docker/default_context_ls Djordje Lukic 2020-06-13 02:40:35 -0700
  • c2a702c963 Ensure the `docker context inspect default` is not executed in a different context, that might make it fail. Following discussion with @simonferquel, this will strengthen the shell out to get default context, in cases the user has damaged his config file current context or there are issues with context synchronisation between windows host & wsl2. Guillaume Tardif 2020-06-13 10:43:23 +0200
  • 376a4b671c version command adding azure integration beta version in textual output Guillaume Tardif 2020-06-12 17:54:14 +0200
  • 130cb87ec9
    Add a target to run docker serve Chad Metcalf 2020-06-12 16:37:42 -0700
  • 39f2093827
    Update classic Docker location depending on OS. Chad Metcalf 2020-06-12 16:29:41 -0700
  • 2e11b2148a
    Merge pull request #206 from docker/fix_typo Guillaume Tardif 2020-06-12 17:01:04 +0200
  • f8ea0934f0 Align login success message with old cli (& with “canceled” message) Guillaume Tardif 2020-06-12 13:49:27 +0200
  • 3c2eb067bc Fix typo in DOCKER ENPOINT Guillaume Tardif 2020-06-12 13:48:11 +0200
  • d9b4564533
    Merge pull request #203 from docker/fix_TestKillChild Guillaume Tardif 2020-06-11 15:30:14 +0200
  • 9d4eed2356 Fix flaky test (subject to running tests in //) Guillaume Tardif 2020-06-11 15:01:43 +0200
  • 3ad1e699a2
    Merge pull request #198 from docker/windows_e2e Guillaume Tardif 2020-06-11 13:51:33 +0200
  • 93623dc5aa
    Merge pull request #200 from docker/context_store_type Guillaume Tardif 2020-06-11 13:34:05 +0200
  • 93984f8c68 Removed test requiring linux containers Guillaume Tardif 2020-06-09 07:22:40 +0200
  • 5258906ce3 Fix windows PATH for e2e tests Guillaume Tardif 2020-06-08 21:52:34 +0200
  • 6bfdded047 Windows CI Guillaume Tardif 2020-06-08 21:13:51 +0200
  • f3f6bff583 Fix linter Guillaume Tardif 2020-06-08 17:30:46 +0200
  • df6fc2f18f Fix volume path setting for linux containers from windows host guillaume.tardif 2020-06-08 21:36:14 +0200
  • c92df92d29 Fix API Server E2E test using npipe on windows, not sockets guillaume.tardif 2020-06-08 17:08:54 +0200
  • bed0b81343 Fix windows E2E suite setup to work properly on windows guillaume.tardif 2020-06-08 16:50:47 +0200
  • c73998bd2d Fix e2e tests using golden files on windows guillaume.tardif 2020-06-08 14:43:51 +0200
  • 07a29e2d0e
    Merge pull request #201 from docker/fix_delegate_errors Guillaume Tardif 2020-06-10 18:24:23 +0200
  • e7682682fb Store context type in metadata to make retrocompatibility with previous contexts easier (potentially switching back and forth) Guillaume Tardif 2020-06-10 14:07:35 +0200
  • 72bae873c5 Do not delegate to old cli if cobra fails before invoking the PreRun or SetHelp hook that call isOwnCommand(). Find the command from root.Find(args). Tried to use `cmd, err := root.ExecuteC()` but I can’t pass the context like with `root.ExecuteContext(ctx)`, could not find a way without and explicit call to root.Find(args) Guillaume Tardif 2020-06-10 17:24:13 +0200
  • 8930563a25
    Merge pull request #194 from docker/dependabot/go_modules/github.com/onsi/gomega-1.10.1 Djordje Lukic 2020-06-10 02:12:45 -0700
  • fa5b3b2291
    Bump github.com/onsi/gomega from 1.9.0 to 1.10.1 dependabot-preview[bot] 2020-06-10 09:07:30 +0000
  • 956237430d
    Merge pull request #199 from docker/fix_login_error Djordje Lukic 2020-06-10 02:04:35 -0700
  • f236c5fa45
    Merge pull request #193 from docker/dependabot/go_modules/github.com/Azure/go-autorest/autorest/adal-0.8.3 Djordje Lukic 2020-06-10 02:03:45 -0700
  • 1639834429
    Merge pull request #196 from rumpl/feat-store-grpc-context Djordje Lukic 2020-06-10 02:03:32 -0700
  • 819a7389f7 Fix login error when login to an azure account having no associated tenant. This was encountered by @lorenrh with stack : ``` docker login azure panic: runtime error: index out of range [0] with length 0 goroutine 1 [running]: github.com/docker/api/azure/login.AzureLoginService.Login(0xc0004cc2a0, 0x2d, 0xe8b8a0, 0x1476830, 0xe8e4e0, 0xc000498ff0, 0x0, 0x0) github.com/docker/api/azure/login/login.go:130 +0x1057 github.com/docker/api/azure.(*aciCloudService).Login(0xc0004888c0, 0xe8e4e0, 0xc000498ff0, 0x0, 0xe82720, 0xc0004888c0) github.com/docker/api/azure/backend.go:283 +0x64 github.com/docker/api/cli/cmd/login.cloudLogin(0xc0004eb600, 0xd422a4, 0x3, 0x1, 0xffffffffffffffff) github.com/docker/api/cli/cmd/login/login.go:53 +0xae github.com/docker/api/cli/cmd/login.runLogin(0xc0004eb600, 0xc00049c5f0, 0x1, 0x1, 0x0, 0x0) github.com/docker/api/cli/cmd/login/login.go:39 +0x15e github.com/spf13/cobra.(*Command).execute(0xc0004eb600, 0xc00049c5d0, 0x1, 0x1, 0xc0004eb600, 0xc00049c5d0) github.com/spf13/cobra@v1.0.0/command.go:842 +0x45a github.com/spf13/cobra.(*Command).ExecuteC(0xc0004a8580, 0xc000498fc0, 0xc41160, 0x1476830) github.com/spf13/cobra@v1.0.0/command.go:950 +0x350 github.com/spf13/cobra.(*Command).Execute(...) github.com/spf13/cobra@v1.0.0/command.go:887 github.com/spf13/cobra.(*Command).ExecuteContext(...) github.com/spf13/cobra@v1.0.0/command.go:880 main.main() github.com/docker/api/cli/main.go:167 +0x68f ``` Guillaume Tardif 2020-06-10 09:36:43 +0200
  • 8400795caf Add the store to the gRPC context Djordje Lukic 2020-06-08 18:34:32 +0200
  • 4b9bdd0e4b
    Bump github.com/Azure/go-autorest/autorest/adal from 0.8.2 to 0.8.3 dependabot-preview[bot] 2020-06-09 07:59:55 +0000
  • a47a2d39c3
    Merge pull request #195 from docker/chore-dependabot-daily Chris Crone 2020-06-09 09:58:49 +0200
  • 43a607a4af
    Merge pull request #192 from docker/dependabot/go_modules/github.com/stretchr/testify-1.6.1 Djordje Lukic 2020-06-09 00:55:18 -0700
  • 9c21e09044 Run dependabot daily instead of weekly Djordje Lukic 2020-06-09 09:45:57 +0200
  • 63bdcad79e
    Bump github.com/stretchr/testify from 1.5.1 to 1.6.1 dependabot-preview[bot] 2020-06-08 21:26:19 +0000
  • 574a378886
    Merge pull request #182 from rumpl/feat-context-server Djordje Lukic 2020-06-08 07:47:35 -0700
  • c8079d61ee Move streams into own package Djordje Lukic 2020-06-06 22:46:35 +0200
  • bb69de1db3 Add context endpoint to set the current context Djordje Lukic 2020-06-06 22:30:04 +0200
  • 22d4d250a9 Move the config into own package and outside of cli Djordje Lukic 2020-06-06 22:22:30 +0200
  • 67fb49c98c
    Merge pull request #179 from rumpl/feat-stream Djordje Lukic 2020-06-08 06:52:56 -0700
  • 660e61ad6d
    Merge pull request #169 from docker/container_id_display Guillaume Tardif 2020-06-08 13:50:04 +0200
  • f1a5f2d6cf Backend is responsible for generating containers IDs and truncate them if wanted/supported for docker ps Guillaume Tardif 2020-06-08 12:07:20 +0200
  • 71087c68be Add exec.ts for an example of exec over gRPC Djordje Lukic 2020-06-05 16:29:08 +0200
  • c34d016fdb Unify protos with client interfaces Djordje Lukic 2020-06-05 16:28:18 +0200
  • e604e7efc9
    Merge pull request #181 from rumpl/fix-logs Djordje Lukic 2020-06-08 00:34:05 -0700
  • 4700364667
    Merge pull request #180 from docker/unknown_comand_error Guillaume Tardif 2020-06-08 09:25:18 +0200
  • 31a0716c87 Use stdcopy if the container doesn't have a tty Djordje Lukic 2020-06-06 14:34:38 +0200
  • e81c7ae8e3
    Merge pull request #185 from docker/dependabot/go_modules/github.com/Azure/azure-sdk-for-go-42.3.0incompatible Djordje Lukic 2020-06-06 15:13:44 -0700
  • b6f8d9cd80
    Bump github.com/Azure/azure-sdk-for-go dependabot-preview[bot] 2020-06-06 21:49:23 +0000
  • 4cc89f577d
    Merge pull request #183 from docker/dependabot/go_modules/google.golang.org/protobuf-1.24.0 Djordje Lukic 2020-06-06 14:44:22 -0700
  • 5951db58c1
    Bump google.golang.org/protobuf from 1.22.0 to 1.24.0 dependabot-preview[bot] 2020-06-06 21:41:25 +0000
  • bd198c741e
    Merge pull request #186 from docker/dependabot/go_modules/github.com/golang/protobuf-1.4.2 Djordje Lukic 2020-06-06 14:38:02 -0700
  • c57cc28f29
    Merge pull request #187 from docker/dependabot/go_modules/github.com/opencontainers/go-digest-1.0.0 Djordje Lukic 2020-06-06 14:37:49 -0700
  • a1d3ba398a
    Merge pull request #184 from docker/dependabot/go_modules/github.com/Azure/go-autorest/autorest-0.10.2 Djordje Lukic 2020-06-06 14:37:34 -0700
  • 5bb15bbf58
    Bump github.com/opencontainers/go-digest from 1.0.0-rc1 to 1.0.0 dependabot-preview[bot] 2020-06-06 21:23:14 +0000
  • cd711e5f6b
    Bump github.com/golang/protobuf from 1.4.1 to 1.4.2 dependabot-preview[bot] 2020-06-06 21:22:53 +0000
  • 3774557392
    Bump github.com/Azure/go-autorest/autorest from 0.10.0 to 0.10.2 dependabot-preview[bot] 2020-06-06 21:21:36 +0000
  • f939dd4d47 Display friendly message if unknown command is available in default context Guillaume Tardif 2020-06-05 17:30:27 +0200
  • 54141a9bdd Do not display exit status when classic cli exit in error Guillaume Tardif 2020-06-05 17:08:42 +0200
  • e84b508e80
    Merge pull request #171 from docker/windows_kill_child_processes Djordje Lukic 2020-06-05 00:42:21 -0700
  • 995d047608 Windows specific : ensure all child processes are killed when parent exits (also works when killing parent). From Desktop code guillaume.tardif 2020-06-04 16:32:21 +0200
  • 7c6b04f28e make e2e TestKillChildOnCancel exec properly on windows guillaume.tardif 2020-06-04 16:31:06 +0200
  • b91eab0544
    Merge pull request #170 from docker/context_create_check Guillaume Tardif 2020-06-04 16:51:11 +0200
  • 4a4b62ded2 Do not allow context creation for unknown types Guillaume Tardif 2020-06-03 19:01:20 +0200
  • e77513c1c8
    Merge pull request #165 from docker/azure_private_images Guillaume Tardif 2020-06-04 15:43:42 +0200
  • 427527d197
    Merge pull request #146 from docker/chore-refactor-azure-login Guillaume Tardif 2020-06-04 10:39:30 +0200
  • e5335adedd Azure: Refactor login errors Christopher Crone 2020-06-04 10:20:39 +0200
  • c37f666c07
    Merge pull request #164 from docker/interactive_context_create Guillaume Tardif 2020-06-03 18:06:41 +0200
  • 35789ace12 Azure: Refactor creation of login server Christopher Crone 2020-05-22 13:38:30 +0200
  • dae54a3c1f
    Merge pull request #166 from docker/grpc_container_errfix Djordje Lukic 2020-06-03 04:12:47 -0700
  • 1c94893d2f Fix slight bug in error handling Guillaume Tardif 2020-06-03 12:20:49 +0200
  • 39140c8ea0 Refactoring, add unit test or various interactive context creation Guillaume Tardif 2020-06-03 12:05:58 +0200
  • 774bfea341 Refactoring, add unit test or various interactive context creation Guillaume Tardif 2020-06-02 23:33:41 +0200
  • 5675763856 Interactive context create, adding method CreateContextData to CloudService interface, so Cloud Backends can provide a custom context creation method. Guillaume Tardif 2020-06-02 09:49:30 +0200
  • 11f1c057dc Allow pulling private images from hub or other registries, as long as the user is logged in against the registry(ies). Registry creds are passed along with the ACI payload (cf https://docs.microsoft.com/en-us/azure/container-registry/container-registry-auth-aci). Manually tested against hub & ACR private repo Guillaume Tardif 2020-06-02 15:29:16 +0200
  • 21b6a2ae71
    Merge pull request #160 from chris-crone/dockerfile-improvements Chris Crone 2020-06-02 12:15:43 +0200
  • 654f9ebbaf Tidy Makefiles Christopher Crone 2020-06-02 11:53:13 +0200
  • 9920fe2284 Remove unused variables Christopher Crone 2020-05-29 12:00:45 +0200
  • 247fa56ee1 More Dockerfile best practices Christopher Crone 2020-05-29 11:30:12 +0200
  • 3a2e16dc7a
    Merge pull request #163 from docker/chore-remove-backend Djordje Lukic 2020-06-02 00:56:37 -0700
  • ec5e61b645
    Merge pull request #162 from docker/login_command Guillaume Tardif 2020-06-02 09:42:38 +0200
  • 45b672a39d Remove unused backend proto Djordje Lukic 2020-06-02 09:40:43 +0200
  • e2b9f5bc57 Move login to root command, delegate to classic login when only one arg and not dot in it Guillaume Tardif 2020-05-29 17:07:48 +0200
  • f1fb80ecc5
    Merge pull request #161 from docker/context_inspect Guillaume Tardif 2020-05-29 15:51:10 +0200
  • 6830724ab9
    Merge pull request #159 from docker/fix_azure_login Djordje Lukic 2020-05-29 06:23:27 -0700
  • 528d47ce08 Add docker context inspect command relying on classic docker Guillaume Tardif 2020-05-29 12:02:07 +0200
  • 01aaec2dbe Fix Azure login : allow getting a backend when no corresponding context already exists with an explicit call from the login command. Will be usefull next for context creation with azure interactive things Guillaume Tardif 2020-05-28 17:37:59 +0200
  • 9097b1f750 Add .git to .dockerignore Christopher Crone 2020-05-29 11:29:28 +0200
  • 832651b1dc
    Merge pull request #157 from docker/kill_child_process_on_cancel Djordje Lukic 2020-05-28 04:53:47 -0700
  • c8acbc33fd
    Merge pull request #158 from docker/azure_backend_dependency Guillaume Tardif 2020-05-28 10:52:01 +0200
  • a948b6e1d0 Remove azure resourceGroupClient from backend initialisation. Several advantages : - less dependencies to init backend. (Will need to work more on this to make login command not need an existing subscription ID) - backend does not get login token at init time. For a long running process (grace server) this would cause issues with token lifetime - we benefit from the client config (polling options especially) set in aci.go, without duplicating stuff Guillaume Tardif 2020-05-28 10:16:42 +0200
  • ea98a2dd78 Fix docker-classic creation makefile target Guillaume Tardif 2020-05-27 18:39:17 +0200
  • cc46f84043 Forward closing signal to docker-classic when closing docker. Note this will not forward Kill signal, impossible to intercept / process this one. Guillaume Tardif 2020-05-27 18:38:51 +0200
  • e630ace677
    Merge pull request #154 from docker/fix_context_inspect_shellout Guillaume Tardif 2020-05-27 17:02:01 +0200