Commit Graph

3 Commits

Author SHA1 Message Date
Maruan Al-Shedivat dc3289ddfc Fix a small bug in giscus template 2023-10-05 00:36:32 -04:00
Maruan 8893d483bc
Update giscus setup via github action (#1792)
giscus settings in `_config.yml` had al-folio repo specified by default.
many users kept these defaults in their own repos, which resulted in
getting comments from blog posts of different users posted to al-folio
discussions. this is undesirable, since users lose control over the
discussions in their blogs.

this PR solves the issue:
- first, we set `giscus.repo` to blank in `_config.yml`. if the field is
kept blank, when the website is built locally, the user will see a
warning saying that giscus comments are misconfigured.
- second, we add a step to the `deploy` workflow that writes repository
name to `giscus.repo` in `_config.yml`. that way, even if `giscus.repo`
field is left black or set to an incorrect repo, it gets correctly
populated at deployment time.

other small changes in this PR are small stylistic adjustments.
2023-10-04 22:27:36 -04:00
Maruan b9f1fc84f2
Add support for giscus comments (#1028)
adds support for comments on posts using https://giscus.app/
2022-12-11 22:33:09 -05:00